Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for enum usage as transaction parameters #3581

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Add tests for enum usage as transaction parameters #3581

merged 3 commits into from
Sep 16, 2024

Conversation

RZhang05
Copy link
Contributor

@RZhang05 RZhang05 commented Sep 12, 2024 •
edited by turbolent
Loading

Closes #3484

Description

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS mentioned this pull request Sep 13, 2024
Closed
SupunS
SupunS reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RZhang05 for adding tests!

It seems this feature is already supported, so nothing really to add. Could you maybe remove the draft status from the PR, so we can get these tests in.

@RZhang05 RZhang05 marked this pull request as ready for review September 13, 2024 23:14
turbolent
turbolent approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great that this was already working.

runtime/program_params_validation_test.go Outdated Show resolved Hide resolved
SupunS
SupunS approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

runtime/program_params_validation_test.go Outdated Show resolved Hide resolved
@SupunS SupunS merged commit 60aeec6 into onflow:master Sep 16, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@SupunS SupunS SupunS approved these changes

Assignees
No one assigned
Labels
Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Enum Types as Direct Transaction Parameters
3 participants
@RZhang05 @turbolent @SupunS