Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests under runtime to tests directory #3621

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Oct 17, 2024

Work towards #526


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Oct 17, 2024
@SupunS SupunS requested a review from turbolent as a code owner October 17, 2024 21:51
@SupunS SupunS changed the title Move tests under 'runtime' to 'tests' directory Move tests under runtime to tests directory Oct 17, 2024
Base automatically changed from supun/restructure to master October 18, 2024 16:10
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 8b904c2
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@SupunS SupunS merged commit 0bb1b69 into master Oct 18, 2024
10 of 12 checks passed
@SupunS SupunS deleted the supun/restructure-2 branch October 18, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants