Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve CCF CDDL in comments #3643

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

fxamacker
Copy link
Member

Changes to CDDL notation and other comments include:

  • Fix entitlement CCF CDDL
  • Remove deprecated path-capability CCF CDDL
  • Update inclusiverange-value CCF CDDL
  • and other minor improvements

The above items were found while updating CCF Specs 1.0-RC3 to 1.0.0 at onflow/ccf:


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker added the Documentation Improvements or additions to documentation label Oct 24, 2024
@fxamacker fxamacker self-assigned this Oct 24, 2024
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit af8e417
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Changes to CDDL notation and other comments include:
- Fix entitlement CCF CDDL
- Remove deprecated path-capability CCF CDDL
- Update inclusiverange-value CCF CDDL
- and other minor improvements
@fxamacker fxamacker force-pushed the fxamacker/update-ccf-cddl-in-comments-2 branch from ccf50a0 to e3c3821 Compare October 24, 2024 01:27
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! 👌

@fxamacker fxamacker merged commit c4e631e into master Oct 24, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants