Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test utils #3652

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Refactor test utils #3652

merged 1 commit into from
Oct 29, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Oct 29, 2024

Work towards #3595

Description

Refactor the various test utils packages into a test_utils "umbrella" package with packages:

  • common_utils: e.g. AssertEqualWithDiff, RequireError
  • sema_utils: e.g. ParseAndCheck
  • interpreter_utils: e.g. NewTestInterpreter, RequireValuesEqual
  • runtime_utils: e.g. TestRuntimeInterface

Also, consistently always import the test util packages as dot imports.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz October 29, 2024 01:04
@turbolent turbolent self-assigned this Oct 29, 2024
@turbolent turbolent requested a review from SupunS as a code owner October 29, 2024 01:04
Base automatically changed from bastian/refactor-tests to master October 29, 2024 21:48
@turbolent turbolent closed this Oct 29, 2024
@turbolent turbolent reopened this Oct 29, 2024
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 0f382af
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent merged commit 63d3591 into master Oct 29, 2024
10 of 12 checks passed
@turbolent turbolent deleted the bastian/refactor-test-utils branch October 29, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants