Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable type removal during contract updates #3658

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Enable type removal during contract updates #3658

merged 2 commits into from
Oct 30, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Oct 30, 2024 •
edited
Loading

Closes #3210

Description

Enable the implementation of FLIP onflow/flips#276, which is currently hidden behind a flag.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Oct 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit efe9b38
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@SupunS SupunS marked this pull request as ready for review October 30, 2024 19:23
@SupunS SupunS requested a review from turbolent as a code owner October 30, 2024 19:23
@SupunS SupunS requested a review from jsproz October 30, 2024 19:24
turbolent
turbolent approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SupunS SupunS merged commit 085280e into master Oct 30, 2024
10 of 12 checks passed
@SupunS SupunS deleted the supun/enable-type-removal branch October 30, 2024 19:31
@BrewTestBot BrewTestBot mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@jsproz jsproz Awaiting requested review from jsproz

Assignees

@SupunS SupunS

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow removing type declarations from contracts
2 participants
@SupunS @turbolent