Optimize member set by using plain Go maps and parent-child chaining #589

turbolent · 2021-02-08T20:50:07Z

Description

Refactor the member set from using HAMT sets to Go map and parent-child chaining, just like in activations.

This improves performance of BenchmarkCheckContractInterfaceFungibleTokenConformance by ~8%.

For contributor use:

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

runtime/interface.go

SupunS · 2021-02-09T15:54:35Z

runtime/sema/member_set.go

+	result := NewMemberSet(nil)
+
+	_ = ms.ForEach(func(member *Member) error {
+		if !otherMS.Contains(member) {


Just a minor suggestion: inverting the condition could reduce the number of return statements to one.

I usually try to structure code with early exits which avoids deep nesting. This also seems to be idiomatic / often seen in Go code.

turbolent added 2 commits February 8, 2021 12:45

optimize member set by using plain Go maps and parent-child chaining

948b6a9

assert that Intersection does not mutate

2c508e2

turbolent added the Improvement label Feb 8, 2021

turbolent requested review from SupunS and janezpodhostnik February 8, 2021 20:50

turbolent self-assigned this Feb 8, 2021

janezpodhostnik reviewed Feb 9, 2021

View reviewed changes

runtime/interface.go Outdated Show resolved Hide resolved

revert removal of UpdateAccountCode

3ccad68

SupunS approved these changes Feb 9, 2021

View reviewed changes

turbolent merged commit 2c2db26 into master Feb 9, 2021

turbolent deleted the bastian/optimize-memberset branch May 18, 2021 17:39