Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Virtual Machine #598

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Improve Virtual Machine #598

merged 2 commits into from
Feb 15, 2021

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 13, 2021 •
edited
Loading

Description

Instead of closing over the wasmtime store/memory in the imports of the module, get the exported memory from the caller argument.

See bytecodealliance/wasmtime-go#57

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Feb 13, 2021
@turbolent turbolent merged commit 6105806 into master Feb 15, 2021
@turbolent turbolent deleted the bastian/improve-vm branch May 18, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

Assignees

@turbolent turbolent

Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @janezpodhostnik