Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for KeyString function #612

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

turbolent
Copy link
Member

Description

Ensure there are no accidental regressions in the KeyString functions.

Key strings are used when encoding dictionaries, so an accidental change without proper backwards-compatibility will lead to storage issues.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent merged commit d725fa9 into master Feb 19, 2021
@turbolent turbolent deleted the bastian/test-key-string branch May 18, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants