Revisions to metadata views documents to go into more depth about how to properly use each view #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
joshuahannan
requested review from
gregsantos,
chasefleming and
sisyphusSmiling
sisyphusSmiling
approved these changes
Jan 8, 2024
| /// The score of the rarity as a number | ||
| access(all) let score: UFix64? | ||
|
|
||
| /// The maximum value of score |
There was a problem hiding this comment.
The current comment is a bit ambiguous to me, but not sure if saying trait rarity is too prescriptive
Suggested change
| /// The maximum value of score | |
| /// The maximum trait rarity score |
| ) | ||
| ``` | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Not a blocker to this PR, but I recently wondered how we'd add SVG data to a Display view. Others might wonder as well and look to this section for guidance.
There was a problem hiding this comment.
Yep, just added a little blurb
|
Love the images @joshuahannan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes onflow/flow-nft#166
Developers need more specific guidance on how to use metadata views. This PR updates the views document
to go into more depth about how to generally use reviews and gives more context, examples, and requirements for specific metadata views, namely royalties and traits.