Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batched EVM transaction walkthrough #983

Merged
merged 19 commits into from
Nov 26, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Nov 13, 2024

Related: onflow/batched-evm-exec-example#7

ℹ️ Please do not merge - plans to coordinate publishing with a blog post, but opening PR for feedback

Description

  • Adds a walkthrough detailing how to conditionally execute multiple EVM transactions in a single Cadence transaction

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 1:02am

@sisyphusSmiling sisyphusSmiling requested a review from a team November 13, 2024 20:08
@sisyphusSmiling sisyphusSmiling self-assigned this Nov 13, 2024
@sisyphusSmiling sisyphusSmiling added the documentation Improvements or additions to documentation label Nov 13, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review November 13, 2024 21:38
@sisyphusSmiling sisyphusSmiling changed the title Add batched EVM transaction walkthrough [DO NOT MERGE] Add batched EVM transaction walkthrough Nov 13, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as draft November 15, 2024 23:35
@sisyphusSmiling sisyphusSmiling changed the title [DO NOT MERGE] Add batched EVM transaction walkthrough Add batched EVM transaction walkthrough Nov 15, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review November 21, 2024 19:22

### Approve ERC721 Transfer

Our example `MaybeMintERC721` contract accepts WFLOW in exchange for minting an NFT. However, the contract cannot move
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great description of what wrapped Flow is, but why would we need it here instead of just regular, unwrapped Flow?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine if it's just to demonstrate the complex chain of transactions, but I'd be explicit as to why.

Co-authored-by: Brian Doyle <briandoyle81@gmail.com>
@sisyphusSmiling sisyphusSmiling merged commit 0860f99 into main Nov 26, 2024
3 checks passed
@sisyphusSmiling sisyphusSmiling deleted the gio/add-cadence-evm-walkthrough branch November 26, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants