Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sandbox #56

Merged
merged 1 commit into from
Sep 22, 2023
Merged

remove sandbox #56

merged 1 commit into from
Sep 22, 2023

Conversation

nialexsan
Copy link
Contributor

Closes #???

Description

Sandbox has been deprecated

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@nialexsan nialexsan requested a review from alse as a code owner September 6, 2023 13:26
@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flow-faucet-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 1:28pm

bthaile
bthaile approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bthaile bthaile merged commit 81259c9 into main Sep 22, 2023
2 of 3 checks passed
@bthaile bthaile deleted the nialexsan/remove-sandbox branch September 22, 2023 23:06
@gregsantos gregsantos mentioned this pull request Dec 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jribbink jribbink jribbink approved these changes

@bthaile bthaile bthaile approved these changes

@alse alse Awaiting requested review from alse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nialexsan @bthaile @jribbink