-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable evm #71
Enable evm #71
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
// | ||
// This will allow you to obtain information about a contract without necessarily knowing anything about it. | ||
// All you need is its address and name and you're good to go! | ||
access(all) contract interface ViewResolver { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the Cadence 1.0 version of this not and other core contracts not yet deployed to the emulator and testnet? I see an address listed for testnet below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet on testnet, but the migrated addresses should be the same AFAIK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll spin up a feature branch from main and target this PR against that so merging doesn't break anything
69ff52a
to
5901ff1
Compare
|
||
account.addPublicKey(publicKey.decodeHex()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method was deprecated, so sigAlgorithm
& hashAlgorithm
were added as transaction parameters to better match the preceding call to encodeKey
which took number
values to define each algo. This allows createAccount
interface (defined below) to remain the same.
Quick update: I think we'll need a docker image that includes Cadence 1.0 + EVM. I've been deving on the pre-release CLI |
Update EVM Branch with Main
Related: #69
Description
This PR establishes a working branch on which to enable the faucet with EVM functionality. To avoid blocking progress on test suite availability, this PR is being marked as review with the intention of adding test suites in future PRs.
evm-enabled
for ongoing evm-related workmain
branchFiles changed
in the Github PR explorer