Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump max duration on all endpoints & fix hashing/signing algorithms #91

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Feb 27, 2024

Description

This PR does 2 things:

  1. Bumps maxDuration to 60s on all API endpoints (only fund.ts was bumped previously, this handles account creation as well)
  2. Fixes hashing/signing algorithms incorrectly numbered. This is an "issue" in @onflow/util-encode-key (see [BUG] Signing algorithm IDs do not match those in Cadence fcl-js#1851) which must be seperately investigated considering upcoming changes to the Cadence 1.0 key management API.

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flow-faucet-crescendo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 6:41am
flow-faucet-testnet ❌ Failed (Inspect) Feb 27, 2024 6:41am

@jribbink jribbink changed the title Bump max duration on all endpoints Bump max duration on all endpoints & fix hashing/signing algorithms Feb 27, 2024
@jribbink jribbink marked this pull request as ready for review February 27, 2024 06:39
@jribbink jribbink merged commit dca9293 into evm-enabled Feb 27, 2024
4 of 5 checks passed
@jribbink jribbink deleted the jribbink/max-duration branch February 27, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant