Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support deeplink #212

Merged
merged 2 commits into from
Jul 24, 2023
Merged

support deeplink #212

merged 2 commits into from
Jul 24, 2023

Conversation

nialexsan
Copy link
Contributor

@nialexsan nialexsan commented Jul 5, 2023 •
edited
Loading

linked PR

testing

  • replace in package.json
...

    "dev": "concurrently \"cross-env FLOW_NETWORK=local expo start\" \"wait-on tcp:8888 && flow dev\" \"flow emulator\" --raw --kill-others",

...

    "@onflow/fcl": "1.5.0-alpha.4",

...
  • run

    rm -rf node_modules && npm i && npm run dev

This was referenced Jul 5, 2023
Open
Merged
@nialexsan nialexsan marked this pull request as ready for review July 5, 2023 19:49
@nialexsan nialexsan requested a review from jribbink July 24, 2023 20:36
jribbink
jribbink approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nialexsan nialexsan merged commit 8588418 into main Jul 24, 2023
@nialexsan nialexsan deleted the nialexsan/deeplink-support branch July 24, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jribbink jribbink jribbink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nialexsan @jribbink