Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'stable-cadence' branch to Cadence 1.0 #222

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Update 'stable-cadence' branch to Cadence 1.0 #222

merged 4 commits into from
Jan 16, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Jan 11, 2024 •
edited
Loading

addresses #221

Some non-trivial changes were needed for this migration...

  • Removes contract addresses from .env and uses flow.json instead, really helps with intellisense (and these were always static anyways)
  • Removes FUSD (there is no stable-cadence version of this & it was broken prior to this anyways)
  • Changes how key is sent to chain (i.e. @onflow/util-encode-key is deprecated, so the components of the key were instead passed manually)

@jribbink jribbink marked this pull request as draft January 11, 2024 06:25
@jribbink jribbink force-pushed the jribbink/stable-cadence branch 2 times, most recently from 437c5fc to b7a63ed Compare January 11, 2024 15:04
@jribbink jribbink changed the title Update to Cadence 1.0 Update 'stable-cadence' branch to Cadence 1.0 Jan 11, 2024
@jribbink jribbink force-pushed the jribbink/stable-cadence branch from b7a63ed to 32d51d2 Compare January 11, 2024 16:38
@jribbink jribbink force-pushed the jribbink/stable-cadence branch from 32d51d2 to 4121feb Compare January 11, 2024 23:48
@jribbink jribbink force-pushed the jribbink/stable-cadence branch from 4b323d2 to 7d54573 Compare January 12, 2024 02:29
@jribbink jribbink marked this pull request as ready for review January 12, 2024 07:04
@jribbink jribbink force-pushed the jribbink/stable-cadence branch from 7d54573 to e5702fa Compare January 12, 2024 17:23
@jribbink jribbink merged commit 26336cf into stable-cadence Jan 16, 2024
1 check passed
@jribbink jribbink deleted the jribbink/stable-cadence branch January 16, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsantos gregsantos Awaiting requested review from gregsantos

@chasefleming chasefleming Awaiting requested review from chasefleming

@nialexsan nialexsan Awaiting requested review from nialexsan

Assignees
No one assigned
Labels
Cadence 1.0
Projects
🌊 Flow 4D
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jribbink @chasefleming @gregsantos