Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow Providers: Non-custodial wallets #28 - Milestone 1 - Lay2 Submission #116

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

louzhixian
Copy link
Contributor

@louzhixian louzhixian commented Oct 31, 2021

Flow Providers: Non-custodial wallets - Milestone 1

Description

This PR is for issue #28.

  • We have complete the design of the wallet.
  • Brief introduction of the features we'll cover and how we'll achieve them.
  • Details about the architecture of key management and user flow.
  • Prospects to the future when we can implement the full version of UniPass on Flow to present a keyless experience for users in an non-custodial way.

Submission Links & Documents

Requirements Check

  • Have have you met the milestone requirements?
    • Yes
  • Have you included tests (if applicable)?
    • No tests for this milestone
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)?
    • No code for this milestone

Other Details

  • Is there anything specific you'd like the PoC to know or review for?

    • UniPass has one of the best account abstraction design, yet it requires RSA signature verification ability from the Layer1 to make it possible.
    • For now we have to use mnemonics as the backup method, which we think is too much for ordinary users.
    • We would like to bring an Internet experience also to Flow users, so maybe we can discuss about this feature after we complete this request.
    • Introduction ariticle about UniPass: https://medium.com/unipass/unipass-your-universal-crypto-identity-in-metaverse-b8b932f9313f
  • Are there other references, documentation, or relevant artifices to mention for this PR (ie. external links to justify design decisions, etc.)?

    • UniPass adheres to a pure web format, so as to achieve maximum compatibility and cross-platform ability, and significantly reduce user cost with instant access through links.
    • We are not compromising on security because of convenience, because we manage the keys through built-in managers of the browsers(SubtleCrypto) and even the devices(Webauthn).

Typo fixes;
Introduction article link added.
@kerrywei kerrywei requested review from srinjoyc and gregsantos and removed request for srinjoyc November 1, 2021 17:03
Copy link

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations @louzhixian and team! 🚀
We have reviewed your included documentation and architectural diagrams and you have met the requirements for Milestone 1. UniPass seems like an interesting solution and we look forward to seeing additional progress on your non-custodial wallet solution.

@kerrywei
Copy link

kerrywei commented Nov 4, 2021

merge in the PR per Greg's comment.
Congratulations, team!

@kerrywei kerrywei merged commit 5eb1c6a into onflow:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants