Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground Feature: Markdown READMEs - Milestone 1 #40

Conversation

hichana
Copy link
Contributor

@hichana hichana commented Sep 23, 2021

Playground Feature: Markdown READMEs - Milestone 1

Description

This PR is for issue #18.

We created wireframe mockups for two user flows for the playground, one for a user who becomes the playground owner, and one for a user who is a visitor to an already-created playground instance.

Submission Links & Documents

N/A

Requirements Check

The mockups demonstrate the ability for the playground project owner to add a title, brief description and a README. It also shows how a viewer of an already-created playground would see all of that data rendered as HTML. We attempted to follow existing design patterns for the UI.

Other Details

none

@psiemens psiemens requested a review from MaxStalker September 24, 2021 00:11
@MaxStalker
Copy link
Contributor

It's a great start, @hichana ! :)

Though I would not hide Fork and Export buttons in that popup. How about we just add another button on the right with label Info, which would open that popup? :)

@psiemens
Copy link
Contributor

Though I would not hide Fork and Export buttons in that popup. How about we just add another button on the right with label Info, which would open that popup? :)

I gave the same feedback to @hichana on a call. He's going to make changes to the prototype for milestone 2 based on this! So I'm going to approve 😄

@psiemens psiemens merged commit 351650f into onflow:main Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants