Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptoDappy Feature: NFT marketplace - Milestone 1 #41

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

ph0ph0
Copy link
Contributor

@ph0ph0 ph0ph0 commented Sep 23, 2021

CryptoDappy Feature: NFT marketplace - Milestone 1

Description

This PR is for issue #5.

  • Provide a summary of the work completed in this PR.
  • List of requirements that are being submitted.

Frontend implementation of the Dappy Market, milestone 1.

Submission Links & Documents

  • Include all links to PRs on other repositories (if required) and be clear as to what it does. Ensure you follow the PR guidelines on the other repositories.
    • Include or highlight any new updates made from a previous submission or milestone.

Link to PR on CryptoDappy repo:
bebner/crypto-dappy#11

Requirements Check

  • Have have you met the milestone requirements? Yes
  • Have you included tests (if applicable)? N/A
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? Yes
  • If this is the last milestone:
    • Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.)
    • Demonstrate that you've met all milestone requirements and highlight any extensions or additional work done.
    • Include a payout structure by percentage for each team member (ie. Bob: 20%, Alice: 80%).

Other Details

  • Is there anything specific you'd like the PoC to know or review for?
  • Are there other references, documentation, or relevant artificats to mention for this PR (ie. external links to justify design decisions, etc.)?

Verified

This commit was signed with the committer’s verified signature.
suemto suem
@psiemens psiemens requested a review from bebner October 3, 2021 14:11
@psiemens
Copy link
Contributor

psiemens commented Oct 6, 2021

Hey @ph0ph0, I talked to @bebner and he said that this is approved.

We're going to wait to merge the PR (bebner/crypto-dappy#11) until submissions close on October 15, but you are approved for milestone 1!

@psiemens psiemens merged commit 1ae5e71 into onflow:main Oct 6, 2021
@ph0ph0
Copy link
Contributor Author

ph0ph0 commented Oct 7, 2021

Brilliant, thanks very much!!!! @psiemens @bebner :)

@ph0ph0 ph0ph0 deleted the issue-5 branch October 7, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants