Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tool: Block explorer GUI - Milestone 1 - BlockPI #48

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

blockpinetwork
Copy link
Contributor

@blockpinetwork blockpinetwork commented Sep 29, 2021

New Tool: Block explorer GUI - Milestone 1 - BlockPI

New Tool: Block explorer GUI - Milestone 1

This PR is for issue #2

  1. Design of blockchain explorer, supporting single/multiple node mode
  2. Developer Faucet
  3. Local accounts support (optional)
  4. Supporting mainnet / testnet / local emulator
  5. Draft UI design

Submission Links & Documents

N/A

Requirements Check

  • Have have you met the milestone requirements? Yes
  • Have you included tests (if applicable)? N/A
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? N/A
  • If this is the last milestone:
    • Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.) N/A
    • Demonstrate that you've met all milestone requirements and highlight any extensions or additional work done. N/A
    • Include a payout structure by percentage for each team member (ie. Bob: 20%, Alice: 80%). N/A

Other Details

  • Is there anything specific you'd like the PoC to know or review for? N/A
  • Are there other references, documentation, or relevant artificats to mention for this PR (ie. external links to justify design decisions, etc.)? N/A

@psiemens psiemens requested review from psiemens and 10thfloor October 3, 2021 14:12
Copy link
Contributor

@10thfloor 10thfloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey all,
Thank you for the submission.

Overall this is the direction we want to see, but the wireframes can be simplified in a few places.

Some notes for improvements on this PR that will need to be made before this submission can be accepted:

  • You can replace "gas" with "fee".
  • Emulator accounts can be created from the UI without needing to create a password. For the mvp, the account creation screen should only need to have a single button the generates an account on the emulator, similar to https://github.com/onflow/fcl-dev-wallet, so no need for password / recovery phrase for your mvp as no wallet is required for direct interactions with the emulator.
  • Having a faucet page is a good idea, this page should be an emulator faucet only. This will simplify things as well.

Thanks again for the submission!
As a next step, you may want to validate your UI ideas by examining the emulator code and emulator outputs, and getting more familiar with the Flow transaction lifecycle. Please post any questions you may have in the flip-fest issue itself.

@blockpinetwork
Copy link
Contributor Author

Hello,
Thank you for your suggestions.

We have made a new UI sign, which contains the emulator controlling and log searching.
Also removed the password / recovery phrase for account creating.

@10thfloor
Copy link
Contributor

Hello, Thank you for your suggestions.

We have made a new UI sign, which contains the emulator controlling and log searching. Also removed the password / recovery phrase for account creating.

Amazing! Will be taking a look shortly.

@10thfloor
Copy link
Contributor

Hello,
just wondering about this, is there a repo link we can view?

@blockpinetwork
Copy link
Contributor Author

@10thfloor
Copy link
Contributor

10thfloor commented Oct 26, 2021

You can check here https://github.com/blockpilabs/flip-fest/tree/main/submissions/issue-2/milestone-1/BlockPI

Great. I think we can accept this for milestone#1! Apologies for the delay with our reviews.

A few things to keep in mind for milestone 2:

  • The scope of this task is to create a block-explorer GUI primarily for the Flow emulator. We would like it to have convenience functionality that is tailored for users of the emulator, as there are already good block explorers for the live networks...

This may not have been super clear in the description, but we're primarily looking for a dev tool, like Ganache (on Ethereum) ... The other networks would be a nice bonus of course, but we'd like your team to focus on emulator functionality for milestone 2

  • Given the scope above you won't need to track Epochs or Staking information, and you can remove the Settings screen, or provide a simple settings screen pre-filled with defaults for the emulator endpoints.

  • I'm unsure about what information you can pull about blocks, from the emulator itself, so if your designs call for specific information you think should appear, but is not available, we can create issues in the emulator repo. Part of this process is helping the Flow team discover gaps in our tooling, based on the needs of the community.

  • I may have missed it, but I see no UI for adding balances (FLOW/FUSD) to an account. We definitely want to have this functionality in any GUI explorer for the emulator.

  • Don't take these suggestions as the only things users might want in an emulator GUI. Try using the cli and the emulator yourself, and find and suggest other use cases. We'd like to see original or unique suggestions as part of a successful submission for milestone 2.

Thanks for your effort, and good luck with milestone 2. Let me know if you have any questions!

Add a 👍🏼 to this comment confirming you've read it, and I'll merge this PR.

@10thfloor 10thfloor merged commit 200d7a4 into onflow:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants