Issue 28, milestone 1 Zay Codes submission.

[aishairzay]

Flow Providers: Non-custodial wallets #28 - Milestone 1

Description

This PR is for issue #28.

• A design document has been provided detailing the intended UI/UX for the non-custodial wallet
• Also included is technical details on how keys will be stored and accessed for creating signatures for authorization requests from the Chrome extension wallet

Submission Links & Documents

• https://faithful-wildflower-73f.notion.site/Zay-Codes-MVP-Wallet-Design-51b50e9f84ce4c2cbc4ad20d8c9dea1c

Requirements Check

• Have have you met the milestone requirements? Yes
• Have you included tests (if applicable)? N/A
• Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? Yes
• If this is the last milestone:
  • Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.)
  • Demonstrate that you've met all milestone requirements and highlight any extensions or additional work done.
  • Include a payout structure by percentage for each team member (ie. Bob: 20%, Alice: 80%).

Other Details

• Is there anything specific you'd like the PoC to know or review for? May reach me on discord amit#4491
• Are there other references, documentation, or relevant artificats to mention for this PR (ie. external links to justify design decisions, etc.)? No

[orodio]

Ive looked at this, and it looks like you are moving in the right direction. We are currently working on a more direct way of FCL talking to browser extensions, which means you would not need the proxy through the iframe/rpc. But otherwise this is looking good. Pinging @gregsantos so he can follow up with some more details.

[OmarMalik]

Hey @gregsantos, following up from the email thread here for the Uncaught EvalError workaround. This error occurs when we import @onflow/fcl into a Chrome Extension.

[OmarMalik]

Also, for the sake of completing this submission for Flow Fest, should we work to integrate our extension with the popup/iframe in the main branch of FCL, or will the extension support be ready in time? (https://github.com/onflow/fcl-js/tree/gsantos/ext-rpc)

[gregsantos]

@OmarMalik extension support should be ready in time. Now working on an alpha release which will include

[aishairzay]

Can this issue be merged/closed out for milestone 1? Is any further review needed on the design doc?

[gregsantos]

Most def @aishairzay! I must have missed merging this for M1. We've reviewed and approved 🚀 Great work!