Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground Feature: Markdown READMEs - Milestone 4 #83

Conversation

hichana
Copy link
Contributor

@hichana hichana commented Oct 27, 2021

Playground Feature: Markdown READMEs - Milestone 4

Description

This PR is for issue #18.

We added support for storing and loading the README data on the backend and updating the GraphQL API. We followed the existing pattern and updated the storage, model and controller to include the new variables. We further added sanitization on save to make sure no untrusted data is stored. The tests were also updated to include tests for the newly introduced fields and sanitization.

Submission Links & Documents

  • Our code submission can be found here #13

Requirements Check

  • Have have you met the milestone requirements? Yes
  • Have you included tests (if applicable)? N/A
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? Yes
  • If this is the last milestone:
    • Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.) Yes
    • Demonstrate that you've met all milestone requirements and highlight any extensions or additional work done. Yes
    • Include a payout structure by percentage for each team member (ie. Bob: 20%, Alice: 80%). @J00LZ: 50%, @hichana 50%)

@MaxStalker
Copy link
Contributor

🎉 Milestone Achieved! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants