Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptoDappy Feature: NFT marketplace #5 - Milestone 2 - Team Ancient Machine #86

Merged
merged 6 commits into from
Nov 8, 2021

Conversation

NguyenIvan
Copy link
Contributor

@NguyenIvan NguyenIvan commented Oct 28, 2021

Special thanks to @bebner for all you help and support!

@NguyenIvan NguyenIvan changed the title Milestone 2 Submission - CryptoDappy Feature: NFT marketplace #5 - Team Ancient Machine CryptoDappy Feature: NFT marketplace #5 - Milestone 2 - Team Ancient Machine Oct 29, 2021
@bebner
Copy link

bebner commented Nov 1, 2021

Hey @NguyenIvan , thanks for the milestone submission that certainly fulfils the requirements from the technical side. One question however: Could you draft up a short document outlining your creation process and giving an overview of the different moving pieces that can be submitted to the Cryptodappy Learning Hub as a mission? This way, everyone else can benefit from your experience.

@NguyenIvan
Copy link
Contributor Author

Hi @bebner, of course I can. Please wait for me.

@NguyenIvan
Copy link
Contributor Author

Hi @bebner,
I added this file to the submission. Please check it out.

@kerrywei kerrywei requested a review from bebner November 6, 2021 00:03
@kerrywei
Copy link

kerrywei commented Nov 8, 2021

merge in the PR per Ben's confirmation offline

@kerrywei kerrywei merged commit 281db73 into onflow:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants