Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bharur.md #93

Closed
wants to merge 1 commit into from
Closed

Create bharur.md #93

wants to merge 1 commit into from

Conversation

0udio
Copy link

@0udio 0udio commented Oct 29, 2021

PR Title

Please format your PR title as follows:

[Issue Name] - Milestone [Milestone #]

Example: CLI Feature: State management - Milestone 1

Description

This PR is for issue (insert issue number here).

Example: This PR is for issue #22

  • Provide a summary of the work completed in this PR.
  • List of requirements that are being submitted.

Submission Links & Documents

  • Include all links to PRs on other repositories (if required) and be clear as to what it does. Ensure you follow the PR guidelines on the other repositories.
    • Include or highlight any new updates made from a previous submission or milestone.

Requirements Check

  • Have have you met the milestone requirements?
  • Have you included tests (if applicable)?
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)?
  • If this is the last milestone:
    • Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.)
    • Demonstrate that you've met all milestone requirements and highlight any extensions or additional work done.
    • Include a payout structure by percentage for each team member (ie. Bob: 20%, Alice: 80%).

Other Details

  • Is there anything specific you'd like the PoC to know or review for?
  • Are there other references, documentation, or relevant artificats to mention for this PR (ie. external links to justify design decisions, etc.)?

@sideninja
Copy link
Contributor

Is there a PR open for this on the CLI I can't find it?

@0udio
Copy link
Author

0udio commented Oct 30, 2021

Is there a PR open for this on the CLI I can't find it?

Yes, PR name is - 'bharur'

@kerrywei kerrywei requested a review from sideninja November 1, 2021 17:27
@kerrywei
Copy link

kerrywei commented Nov 1, 2021

(assigned a reviewer to keep track of who is reviewing what )

@sideninja
Copy link
Contributor

I don't see any open PRs on the flow-cli repo, can you please send me the link to the implementation?

@kerrywei
Copy link

kerrywei commented Nov 4, 2021

I don't see any open PRs on the flow-cli repo, can you please send me the link to the implementation?

@0udio ^
Can you please update the contents of this PR as well, to better describe the changes you have made based on https://github.com/onflow/flip-fest/blob/main/pull_request_template.md ?

@kerrywei kerrywei marked this pull request as draft November 4, 2021 18:41
@kerrywei
Copy link

kerrywei commented Nov 4, 2021

converting this to draft for now. @0udio feel free to turn this back to a ready-to-review PR once the comments are addressed. thank you

@kerrywei
Copy link

kerrywei commented Nov 9, 2021

closing this PR as FLIP FEST implementation stage is over and unfortunately we do not see enough progress in https://github.com/0udio/bharur

@kerrywei kerrywei closed this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants