Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow-Rust-SDK - Milestone 4 Completed #96

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

MarshallBelles
Copy link
Contributor

Flow-Rust-SDK - Milestone 4

This PR is for issue #20.

Milestone 4 Completion:

Authors include:

@marshallbelles - 90%
@bluesign - 10%

@kerrywei kerrywei requested a review from sideninja November 1, 2021 17:28
@kerrywei
Copy link

kerrywei commented Nov 1, 2021

(assigned a reviewer to help keep track of who is reviewing what)

@MarshallBelles
Copy link
Contributor Author

@sideninja just fixed the merge issue.

@MarshallBelles
Copy link
Contributor Author

MarshallBelles commented Nov 5, 2021

@sideninja do I need to worry about these getting merged before Monday?
Or does that not matter as long as it's approved?

@kerrywei
Copy link

kerrywei commented Nov 5, 2021

@sideninja do I need to worry about these getting merged before Monday? Or does that not matter as long as it's approved?

Hello @MarshallBelles , you do not need to worry about merging in this PR. As long as @sideninja does not have further suggestions, we'll soon merge in this PR for you

@fee1-dead
Copy link
Contributor

Hello @MarshallBelles, I cloned your repository and found some problems, I opened MarshallBelles/flow-rust-sdk#3. Hope the issues get fixed soon.

@MarshallBelles
Copy link
Contributor Author

Hello @MarshallBelles, I cloned your repository and found some problems, I opened MarshallBelles/flow-rust-sdk#3. Hope the issues get fixed soon.

Fixed.

@kerrywei
Copy link

kerrywei commented Nov 8, 2021

merg in the PR per @sideninja 's approval

@kerrywei kerrywei merged commit 2b50986 into onflow:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants