Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve entitlement mappings #94

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Improve entitlement mappings #94

merged 4 commits into from
Jun 23, 2023

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented May 31, 2023

No description provided.

@SupunS SupunS force-pushed the supun/entitlement-improvements branch from 39cbfd4 to 10493a1 Compare May 31, 2023 19:15
@SupunS SupunS self-assigned this May 31, 2023
@SupunS SupunS force-pushed the supun/entitlement-improvements branch from 10493a1 to ca2dc25 Compare May 31, 2023 20:17
@SupunS SupunS marked this pull request as ready for review June 1, 2023 14:48
cadence/20211129-entitlement-improvements.md Outdated Show resolved Hide resolved
cadence/20211129-entitlement-improvements.md Outdated Show resolved Hide resolved
cadence/20211129-entitlement-improvements.md Outdated Show resolved Hide resolved
cadence/20211129-entitlement-improvements.md Outdated Show resolved Hide resolved
@SupunS SupunS force-pushed the supun/entitlement-improvements branch from ca2dc25 to 1169af1 Compare June 1, 2023 16:09
@SupunS SupunS force-pushed the supun/entitlement-improvements branch from 88a0769 to 626c3a7 Compare June 1, 2023 19:47
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@turbolent turbolent requested a review from dsainati1 June 12, 2023 19:01
@bjartek
Copy link
Contributor

bjartek commented Jun 19, 2023

+1 i really like the usability improvements this gives!

@turbolent
Copy link
Member

@SupunS let's approve and merge 🎉

@SupunS
Copy link
Member Author

SupunS commented Jun 23, 2023

Thanks everyone for the suggestions and feedback!

This FLIP has been open for a while, and it seems we are all happy with the proposed improvement.
Thus, I'm going to consider this FLIP as accepted 🎉 🎉 🎉

You can follow how the implementation is progressing here ➡️ onflow/cadence#2536

@SupunS SupunS merged commit 81ae4a4 into main Jun 23, 2023
@SupunS SupunS deleted the supun/entitlement-improvements branch June 23, 2023 15:37
dsainati1 pushed a commit that referenced this pull request Jul 11, 2023
* Add proposal to improve entitlements

* Extract identity mapping to a separate section. Improve FLIP in general

* Add reference to the 'vision'

* Update status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants