Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation message for dev command #1799

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Oct 23, 2024

prep for #1794
#1798

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.47%. Comparing base (606ca7a) to head (876962b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1799   +/-   ##
=======================================
  Coverage   28.47%   28.47%           
=======================================
  Files          95       95           
  Lines        6490     6490           
=======================================
  Hits         1848     1848           
  Misses       4462     4462           
  Partials      180      180           
Flag Coverage Δ
unittests 28.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming chasefleming marked this pull request as draft November 5, 2024 21:27
@nialexsan nialexsan mentioned this pull request Nov 7, 2024
@nialexsan nialexsan self-assigned this Nov 15, 2024
@chasefleming chasefleming marked this pull request as ready for review November 20, 2024 20:59
@chasefleming chasefleming merged commit c73ef4e into master Nov 20, 2024
7 checks passed
@chasefleming chasefleming deleted the cf/dev-dep-msg branch November 20, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants