Nialexsan/update scaffolds #1827
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1827 +/- ##
=======================================
Coverage 28.47% 28.47%
=======================================
Files 95 95
Lines 6490 6490
=======================================
Hits 1848 1848
Misses 4462 4462
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
nialexsan
requested review from
Kay-Zee,
janezpodhostnik,
chasefleming,
nvdtf,
bluesign,
bjartek and
jribbink
as code owners
| @@ -13,9 +13,17 @@ | |||
| "commit": "8065287e55bc298d776665bef98a577ceb4a226c" | |||
| }, | |||
| { | |||
| "name": "Cadence NFT Project", | |||
| "repo": "https://github.com/nvdtf/flow-nft-scaffold.git", | |||
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
this project was not published, but now it is
it seems Navid took it down and restored later
| "description": "Scaffold contains the ExampleNFT sample NFT contract.", | ||
| "commit": "ef9437c05549e3f581cf619dec9d59d8c7f6e3ec" | ||
| "name": "FCL React Dapp Starter", | ||
| "repo": "https://github.com/nialexsan/fcl-nextjs-quickstart.git", |
There was a problem hiding this comment.
We already have a Next scaffold. This is also very opinionated as the other is stripped down. e.g. CSS framework included.
There was a problem hiding this comment.
this project was mentioned in the flow overview document:
https://developers.flow.com/ecosystem/overview
|
Who is asking for this? We've removed a lot of scaffolds because they quickly get out of date and are hard to maintain. The goal was to move more towards reducing the scaffolds entirely. This puts us in the other direction. |
|
the initial take on this was to replace scaffolds with starters, which seems to be the same thing with a different name |
Closes #1795
Description
updated scaffolds/starters
For contributor use:
masterbranchFiles changedin the Github PR explorer