-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable coverage reporting for emulator #969
Enable coverage reporting for emulator #969
Conversation
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
=========================================
- Coverage 2.53% 2.52% -0.01%
=========================================
Files 5 5
Lines 434 435 +1
=========================================
Hits 11 11
- Misses 422 423 +1
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@m-Peter should we merge? |
@sideninja Yes, of course! We are just awaiting this to be included in a release, before publicly announcing the new features to the dev community 🙏 |
@m-Peter could we add docs on this to the CLI, how you run it and maybe an example? |
@sideninja I have created an entire repository with detailed usage of these new features: https://github.com/Build-Squad/flow-code-coverage/blob/385067c991608e7a37eba742bd857fab136ebeb0/README.md. I am just waiting for a new release of |
@m-Peter sure that makes sense. The thing required tho is to document the flags as part of the CLI docs. |
@m-Peter sorry for not making it clearer, what I meant was adding the docs for flags here https://github.com/onflow/flow-cli/blob/master/docs/run-tests.md |
@sideninja Ah, thanks. I am already updating that document. I will ping you soon 🙏 |
@m-Peter looks good. Let me merge and I can make a release EOT. |
@sideninja That would be great 💯 |
Work towards onflow/developer-grants#132
Description
Allows developers to start the emulator with coverage reporting, which can be viewed in the browser, on this URL:
The respective flag (
--coverage-reporting
) can be used like this:It also adds an HTTP endpoint for flushing/resetting all the collected coverage report, on this URL:
This endpoint accepts only a
PUT
verb, at the moment. For example:curl -XPUT 'http://localhost:8080/emulator/codeCoverage/reset'
Special thanks to @bluesign, for his great ideas 🙌
Special thanks to @turbolent, for his great reviews, which have unblocked this 💯
For contributor use:
master
branchFiles changed
in the Github PR explorer