Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated flow-go/onflow/crypto #554

Closed
wants to merge 2 commits into from
Closed

Replace deprecated flow-go/onflow/crypto #554

wants to merge 2 commits into from

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Jan 26, 2024

onflow/flow-go/crypto is deprecated and replaced by onflow/crypto. This PR replaces the package usage in the code base.

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@tarakby tarakby force-pushed the tarak/use-onflow-crypto branch from 673c05a to 02ce74b Compare January 26, 2024 15:08
@SupunS
Copy link
Member

SupunS commented Jan 26, 2024

Think #552 already include these changes

@tarakby
Copy link
Contributor Author

tarakby commented Jan 26, 2024

Closing as it is covered by #552

@tarakby tarakby closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik will be requested when the pull request is marked ready for review janezpodhostnik is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign will be requested when the pull request is marked ready for review bluesign is a code owner

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming will be requested when the pull request is marked ready for review chasefleming is a code owner

@jribbink jribbink Awaiting requested review from jribbink jribbink will be requested when the pull request is marked ready for review jribbink is a code owner

@peterargue peterargue Awaiting requested review from peterargue peterargue will be requested when the pull request is marked ready for review peterargue is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarakby @SupunS