Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve conversion of EVM addresses #110

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

turbolent
Copy link
Member

Description

Use toConstantSized function to convert [UInt8] to [UInt8;20] needed for EVM.EVMAddress


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from a team as a code owner August 26, 2024 18:01
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (a9d52f9) to head (5a46d92).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files          17       17           
  Lines         922      922           
=======================================
  Hits          796      796           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling
Copy link
Contributor

Thanks for the PR @turbolent! I'm not able to make commit suggestions as they span deleted lines. Could you update the changes to utilize EVM.addressFromString as was used in https://github.com/onflow/flow-port/pull/310 please? Or just let me know if you'd rather I do it and I can push the changes to this branch

@turbolent
Copy link
Member Author

@sisyphusSmiling good idea, done in 5a46d92

@sisyphusSmiling sisyphusSmiling merged commit 3e8011f into main Aug 30, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the bastian/improve-evm-addresses branch August 30, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants