-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata discovery & resolution paths to escrow contracts #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful error messages! 👏 🥳
Would it be possible to have a method here to get do the two following things? and to get the views and resolve them for subnfts aswell? Maybe that is another issue. Granted not very many people have subnfts that are bridge but it would still be nice to have if that ever happends. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 86.33% 87.28% +0.94%
==========================================
Files 17 17
Lines 922 920 -2
==========================================
+ Hits 796 803 +7
+ Misses 126 117 -9 ☔ View full report in Codecov by Sentry. |
Merging in preparation for mainnet migration test today, but feel free to review and request changes after the fact @joshuahannan |
Closes: #112 cc: @bjartek
Related: #99
Description
For contributor use:
main
branchFiles changed
in the Github PR explorer