-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new transaction for creating new account with coa #130
Conversation
- Mainly from the usage of CEXs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 86.19% 86.70% +0.50%
==========================================
Files 18 18
Lines 884 970 +86
==========================================
+ Hits 762 841 +79
- Misses 122 129 +7 ☔ View full report in Codecov by Sentry. |
FYI @franklywatson pointed me to the original code and I have created an issue to update the original transaction: onflow/flow-core-contracts#460 |
Updated the transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
Co-authored-by: Giovanni Sanchez <108043524+sisyphusSmiling@users.noreply.github.com>
Description
This transaction is mainly used by CEXs.
It is a combined transaction for creating new accounts and creating COA resources.
Help CEX create COA addresses at the same time when creating user Flow deposit addresses.
For contributor use:
main
branchFiles changed
in the Github PR explorer