Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new transaction for creating new account with coa #130

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

btspoony
Copy link
Contributor

@btspoony btspoony commented Oct 22, 2024

Description

This transaction is mainly used by CEXs.
It is a combined transaction for creating new accounts and creating COA resources.
Help CEX create COA addresses at the same time when creating user Flow deposit addresses.


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@btspoony btspoony requested a review from a team as a code owner October 22, 2024 08:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (02aab3f) to head (653fb06).
Report is 156 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   86.19%   86.70%   +0.50%     
==========================================
  Files          18       18              
  Lines         884      970      +86     
==========================================
+ Hits          762      841      +79     
- Misses        122      129       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarakby
Copy link

tarakby commented Oct 22, 2024

FYI @franklywatson pointed me to the original code and I have created an issue to update the original transaction: onflow/flow-core-contracts#460

@btspoony
Copy link
Contributor Author

Updated the transaction.

Copy link

@tarakby tarakby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

Co-authored-by: Giovanni Sanchez <108043524+sisyphusSmiling@users.noreply.github.com>
@sisyphusSmiling sisyphusSmiling merged commit 2f2ba05 into main Oct 25, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the bohao/add-create-new-acct-with-coa branch October 25, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants