Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up removal of CadenceBlocklist init #140

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Dec 20, 2024

Description

  • Removes the CadenceBlocklist initialization method from FlowEVMBridgeConfig

For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling force-pushed the gio/add-cadence-onboarding-blocklist-followup branch from 0ce5fdd to 28c77e8 Compare December 20, 2024 00:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.63%. Comparing base (02aab3f) to head (28c77e8).
Report is 186 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   86.19%   86.63%   +0.44%     
==========================================
  Files          18       18              
  Lines         884      973      +89     
==========================================
+ Hits          762      843      +81     
- Misses        122      130       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review December 20, 2024 00:21
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner December 20, 2024 00:21
@sisyphusSmiling sisyphusSmiling merged commit 4f7dde0 into main Dec 20, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the gio/add-cadence-onboarding-blocklist-followup branch December 20, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants