Docker file #45

nialexsan · 2024-02-09T14:38:34Z

Closes: #???

Description

Dockerfile for a build to deploy

For contributor use:

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the standards mentioned here.
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

m-Peter · 2024-02-12T13:24:21Z

.github/workflows/deploy.yml

@@ -2,8 +2,8 @@ name: "Deploy EVM Gateway to Cloud Run"

 on:
  push:
-    branches:
-      - main
+    # branches:


Is this intentional? Do we want them to be commented-out?

I'll revert these changes, they were only for testing

m-Peter · 2024-02-12T13:25:47Z

api/server_test.go

@@ -45,7 +45,7 @@ func TestServerJSONRPCOveHTTPHandler(t *testing.T) {
 	blockchainAPI := api.NewBlockChainAPI(config, store, mockFlowClient)
 	supportedAPIs := api.SupportedAPIs(blockchainAPI)
 	srv.EnableRPC(supportedAPIs)
-	srv.SetListenAddr("localhost", 8545)
+	srv.SetListenAddr("", 8545)


I'm curious, did you encounter a problem with "localhost"?

yes, there was an issue in cloud run
it's a specific requirement for cloud run

The ingress container within an instance must listen for requests on 0.0.0.0 on the port to which requests are sent.

https://cloud.google.com/run/docs/container-contract

Similar comment as above about the port needing to be an injected variable

m-Peter · 2024-02-12T13:29:28Z

Dockerfile

+RUN CGO_ENABLED=0 go build -o evm-gateway ./cmd/server/main.go
+RUN chmod a+x evm-gateway
+RUN chmod a+x ./scripts/run.sh
+RUN git clone https://github.com/m-Peter/flow-cli-custom-builds.git


Minor, I run into a glitch the first time building the image locally:

> [builder 10/10] RUN git clone https://github.com/m-Peter/flow-cli-custom-builds.git: 0.344 Cloning into 'flow-cli-custom-builds'... 66.27 error: 3872 bytes of body are still expected 66.28 fetch-pack: unexpected disconnect while reading sideband packet 66.29 fatal: early EOF 66.31 fatal: fetch-pack: invalid index-pack output ------ ERROR: failed to solve: executor failed running [/bin/sh -c git clone https://github.com/m-Peter/flow-cli-custom-builds.git]: exit code: 128

Maybe another alternative could be:

RUN wget https://github.com/m-Peter/flow-cli-custom-builds/raw/main/flow-x86_64-linux- RUN chmod a+x flow-x86_64-linux-

With the 2nd attempt, I was able to build the image and run a container, so it is not a big deal.

m-Peter

LGTM! 🚀
I built an image locally and ran the container. It worked very well 👏

franklywatson · 2024-02-12T23:31:29Z

Dockerfile

+COPY --from=builder /flow-evm-gateway/flow.json /flow-evm-gateway/flow.json 
+COPY --from=builder /flow-evm-gateway/api/cadence/transactions/create_bridged_account.cdc /flow-evm-gateway/create_bridged_account.cdc 
+COPY --from=builder /flow-evm-gateway/scripts/run.sh /flow-evm-gateway/run.sh
+EXPOSE 8545


We'll need to expose this so it can be templated and set externally

franklywatson · 2024-02-12T23:31:53Z

api/server_test.go

@@ -45,7 +45,7 @@ func TestServerJSONRPCOveHTTPHandler(t *testing.T) {
 	blockchainAPI := api.NewBlockChainAPI(config, store, mockFlowClient)
 	supportedAPIs := api.SupportedAPIs(blockchainAPI)
 	srv.EnableRPC(supportedAPIs)
-	srv.SetListenAddr("localhost", 8545)
+	srv.SetListenAddr("", 8545)


Similar comment as above about the port needing to be an injected variable

franklywatson · 2024-02-12T23:32:04Z

api/server_test.go

@@ -460,7 +460,7 @@ func TestServerJSONRPCOveWebSocketHandler(t *testing.T) {
 	blockchainAPI := api.NewBlockChainAPI(config, store, flowClient)
 	supportedAPIs := api.SupportedAPIs(blockchainAPI)
 	srv.EnableWS(supportedAPIs)
-	srv.SetListenAddr("localhost", 8545)
+	srv.SetListenAddr("", 8545)


Same comment

franklywatson · 2024-02-12T23:32:13Z

cmd/server/main.go

@@ -182,7 +182,7 @@ func runServer(config *api.Config, store *storage.Store, logger zerolog.Logger)
 	srv.EnableRPC(supportedAPIs)
 	srv.EnableWS(supportedAPIs)

-	srv.SetListenAddr("localhost", 8545)
+	srv.SetListenAddr("", 8545)


franklywatson · 2024-02-12T23:33:06Z

scripts/run.sh

+
+# Run the second process
+
+./flow-x86_64-linux- transactions send /flow-evm-gateway/create_bridged_account.cdc 1500.0 --network=emulator --signer=emulator-account && ./evm-gateway


We will need to be able to pass in the network to be used, whether emulator or other network

nialexsan added 2 commits February 9, 2024 09:37

Docker file

56879c9

test deployment

d01b36b

nialexsan temporarily deployed to staging February 9, 2024 14:41 — with GitHub Actions Inactive

nialexsan temporarily deployed to production February 9, 2024 14:41 — with GitHub Actions Inactive

franklywatson approved these changes Feb 9, 2024

View reviewed changes

nialexsan added 4 commits February 9, 2024 14:33

tweak dockerfile

d47f861

clone via https

38dc2a9

Merge remote-tracking branch 'origin/main' into nialexsan/docker

472e3fc

fix port

929027f

nialexsan temporarily deployed to staging February 9, 2024 19:47 — with GitHub Actions Inactive

nialexsan temporarily deployed to production February 9, 2024 19:47 — with GitHub Actions Inactive

fixed paths

5d22705

nialexsan temporarily deployed to staging February 9, 2024 19:58 — with GitHub Actions Inactive

nialexsan temporarily deployed to production February 9, 2024 19:58 — with GitHub Actions Inactive

run script

8fa33ed

nialexsan temporarily deployed to staging February 10, 2024 01:21 — with GitHub Actions Inactive

nialexsan temporarily deployed to production February 10, 2024 01:21 — with GitHub Actions Inactive

listen on port

429c349

nialexsan temporarily deployed to production February 10, 2024 01:38 — with GitHub Actions Inactive

nialexsan temporarily deployed to staging February 10, 2024 01:38 — with GitHub Actions Inactive

nialexsan requested a review from m-Peter February 10, 2024 02:23

m-Peter reviewed Feb 12, 2024

View reviewed changes

m-Peter approved these changes Feb 12, 2024

View reviewed changes

address PR comments

63d70ae

franklywatson reviewed Feb 12, 2024

View reviewed changes

nialexsan merged commit ff69c7e into main Feb 12, 2024
1 check passed

m-Peter deleted the nialexsan/docker branch March 8, 2024 13:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docker file #45

Docker file #45

nialexsan commented Feb 9, 2024

m-Peter Feb 12, 2024

nialexsan Feb 12, 2024

m-Peter Feb 12, 2024

nialexsan Feb 12, 2024

franklywatson Feb 12, 2024

m-Peter Feb 12, 2024

m-Peter left a comment

franklywatson Feb 12, 2024

franklywatson Feb 12, 2024

franklywatson Feb 12, 2024

franklywatson Feb 12, 2024

franklywatson Feb 12, 2024


		# Run the second process

		./flow-x86_64-linux- transactions send /flow-evm-gateway/create_bridged_account.cdc 1500.0 --network=emulator --signer=emulator-account && ./evm-gateway

Docker file #45

Docker file #45

Conversation

nialexsan commented Feb 9, 2024

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-Peter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment