Optimize traces engine to handle empty blocks

[m-Peter]

Closes: #464

Description

The traces engine performs some unnecessary actions, now that we can have blocks with no transactions. This will avoid spawning go routines for a no-op action.
We also remove the initEVMHeight from NewTracesIngestionEngine as it seems to be not used for anything.

---

For contributor use:

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the standards mentioned here.
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

Summary by CodeRabbit

• New Features

  • Enhanced efficiency in the trace ingestion process by optimizing how blocks with no transactions are handled.

• Bug Fixes

  • Removed unnecessary initialization of block height, which may improve ingestion reliability.

• Refactor

  • Simplified the initialization process for the traces ingestion engine, streamlining the handling of initial state.

• Style

  • Improved readability of test function calls for better clarity in code presentation.

[coderabbitai]

Walkthrough

The changes involve modifications to the traces ingestion process in the codebase. Key alterations include the removal of the initHeight variable in the startIngestion function and the corresponding adjustments in the NewTracesIngestionEngine function. Additionally, the Notify method now includes an early return condition for empty transaction blocks, enhancing efficiency. These updates aim to optimize how the engine handles blocks that contain no transactions.

Changes

Files	Change Summary
bootstrap/bootstrap.go, services/traces/engine.go	Removed the initHeight variable in startIngestion and the initEVMHeight parameter in NewTracesIngestionEngine, streamlining block ingestion and initialization. Added early return in Notify method for empty transaction hashes.
services/traces/engine_test.go	Modified formatting of NewTracesIngestionEngine function calls in tests for improved readability without affecting functionality.

Assessment against linked issues

Objective	Addressed	Explanation
Optimize traces engine to handle empty blocks (#464)	✅

🐇 Hopping through code with glee,
Our traces engine's now so free!
No empty blocks will cause a fuss,
With tidy code, we’re safe to trust.
Let’s leap ahead, all bugs we’ll shoo,
For every hop, there’s something new! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between daa037a and a5f395e.

Files selected for processing (3)

• bootstrap/bootstrap.go (1 hunks)
• services/traces/engine.go (3 hunks)
• services/traces/engine_test.go (3 hunks)

Files skipped from review due to trivial changes (1)

• services/traces/engine_test.go

Additional comments not posted (3)

services/traces/engine.go (2)

67-71: Efficient handling of empty blocks.

The early return condition for empty transaction blocks in the Notify method optimizes performance by avoiding unnecessary processing.

---

Line range hint 22-36: Verify the impact of removing initEVMHeight.

The initEVMHeight parameter has been removed from the NewTracesIngestionEngine function. Ensure that this change does not affect the engine's initialization logic or any dependent components.

Run the following script to check for any remaining references to initEVMHeight in the codebase:

Verification successful

---

No remaining references to initEVMHeight found.

The initEVMHeight parameter has been removed from the NewTracesIngestionEngine function, and there are no remaining references to it in the codebase. This change does not appear to affect the engine's initialization logic or any dependent components.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for references to `initEVMHeight` in the codebase.

# Test: Search for any remaining references to `initEVMHeight`.
rg --type go 'initEVMHeight'

Length of output: 28

bootstrap/bootstrap.go (1)

Line range hint 116-139: Verify the impact of removing initHeight.

The initialization of the initHeight variable and its associated error handling have been removed from the startIngestion function. Ensure that this change does not impact the ingestion logic or any dependent components.

Run the following script to check for any remaining references to initHeight in the codebase: