Skip to content

Handle ErrHeightOutOfRange errors in EstimateGas #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Handle ErrHeightOutOfRange errors in EstimateGas #498

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54ff0cc
Handle ErrHeightOutOfRange errors in EstimateGas
m-Peter Aug 30, 2024
1ac2549
Merge branch 'main' into improve-estimate-gas-error-handling
devbugging Sep 2, 2024
24dfdf3
Merge branch 'main' into improve-estimate-gas-error-handling
devbugging Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions services/requester/requester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ func (e *EVM) Call(
Uint64("cadence-height", height).
Int64("evm-height", evmHeight).
Str("from", from.String()).
Str("data", string(data)).
Str("data", hex.EncodeToString(data)).
Msg("failed to execute call")
}
return nil, fmt.Errorf("failed to execute script at height: %d, with: %w", height, err)
Expand Down Expand Up @@ -529,6 +529,15 @@ func (e *EVM) EstimateGas(
[]cadence.Value{hexEncodedTx, hexEncodedAddress},
)
if err != nil {
if !errors.Is(err, errs.ErrHeightOutOfRange) {
e.logger.Error().
Err(err).
Uint64("cadence-height", height).
Int64("evm-height", evmHeight).
Str("from", from.String()).
Str("data", hex.EncodeToString(data)).
Msg("failed to execute estimateGas")
}
return 0, fmt.Errorf("failed to execute script at height: %d, with: %w", height, err)
}

Expand All @@ -541,7 +550,9 @@ func (e *EVM) EstimateGas(

e.logger.Debug().
Uint64("gas", gasConsumed).
Msg("gas estimation executed")
Int64("evm-height", evmHeight).
Uint64("cadence-height", height).
Msg("estimateGas executed")

return gasConsumed, nil
}
Expand Down