Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cadence testing framework for ExampleToken contract #137

Merged
merged 6 commits into from
Jun 29, 2023

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented Jun 27, 2023

Work towards: onflow/developer-grants#148

Description

Uses the Cadence testing framework to test the ExampleToken smart contract.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels
  • Update the version in package.json when there is a change in the smart contracts

@m-Peter m-Peter requested a review from joshuahannan as a code owner June 27, 2023 13:25
@m-Peter m-Peter force-pushed the switch-testing-to-cadence branch 2 times, most recently from 67582d2 to ef23bf5 Compare June 27, 2023 13:40
@m-Peter m-Peter force-pushed the switch-testing-to-cadence branch from ef23bf5 to 49d376e Compare June 27, 2023 13:52
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for making these changes! This is way cleaner. I just had a few comments but everything looks pretty good so far. 😃

@m-Peter m-Peter requested a review from joshuahannan June 28, 2023 15:30
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments! The changes look really good. Did all the tests pass when you ran make test? I need to see why CI isn't running here for you

@m-Peter
Copy link
Contributor Author

m-Peter commented Jun 29, 2023

@joshuahannan Both make test & make ci pass locally, and in the GitHub workflow. However, the branch of the PR is coming from a fork, probably that's why it is not running here, but rather in our fork: https://github.com/Build-Squad/flow-ft/actions/runs/5401591136

@m-Peter m-Peter changed the title Switch testing to cadence for ExampleToken contract Use Cadence testing framework for ExampleToken contract Jun 29, 2023
@joshuahannan joshuahannan merged commit 74e40c3 into onflow:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants