Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include metadata views on README.md #93

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Include metadata views on README.md #93

merged 5 commits into from
Oct 5, 2022

Conversation

alilloig
Copy link
Member

@alilloig alilloig commented Sep 19, 2022 •
edited
Loading

Closes: #84

Description

Detailed explanation of the new views and how to use them and where to find the examples.

For contributor use:

  • Targeted PR against alilloig/example-token-metadata-views branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels
  • Update the version in package.json when there is a change in the smart contracts

@alilloig alilloig self-assigned this Sep 19, 2022
@alilloig alilloig added documentation Improvements or additions to documentation T-Documentation 📃 Feature labels Sep 19, 2022
joshuahannan
joshuahannan reviewed Sep 19, 2022
View reviewed changes
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna wait to review this until we get my comments resolved in the other PR, there are some bigger changes that might be needed. Also, the target branch for this should be your metadata views feature branch, not master

@alilloig alilloig changed the base branch from master to alilloig/example-token-metadata-views September 19, 2022 16:05
@alilloig
Copy link
Member Author

I'm gonna wait to review this until we get my comments resolved in the other PR, there are some bigger changes that might be needed. Also, the target branch for this should be your metadata views feature branch, not master

great and fixed!

@alilloig alilloig merged commit 2045a1d into alilloig/example-token-metadata-views Oct 5, 2022
@alilloig alilloig deleted the alilloig/docs-metadata-views branch October 5, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuahannan joshuahannan joshuahannan left review comments

@satyamakgec satyamakgec Awaiting requested review from satyamakgec

@ggpt-labs ggpt-labs Awaiting requested review from ggpt-labs

@sisyphusSmiling sisyphusSmiling Awaiting requested review from sisyphusSmiling

Assignees

@alilloig alilloig

Labels
documentation Improvements or additions to documentation Feature T-Documentation 📃
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOCS: Update FT documentation to include Metadata Views including examples
2 participants
@alilloig @joshuahannan