Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion error logs is not descriptive enough #791

Open
illia-malachyn opened this issue Oct 22, 2024 · 1 comment
Open

Conversion error logs is not descriptive enough #791

illia-malachyn opened this issue Oct 22, 2024 · 1 comment

Comments

@illia-malachyn
Copy link
Contributor

We should probably add more context to every usage of ErrEmptyMessage. The error makes sense only if used as a top-level error. However, there's no instrument to prevent a developer from using it for included messages that might also be empty.

onflow/flow-go#6571 (comment)
@illia-malachyn
Copy link
Contributor Author

cc @peterargue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
🌊 Flow 4D
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@illia-malachyn