-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Cadence v1.2.1, Move Cadence Crypto
contract on-chain
#6571
Update to Cadence v1.2.1, Move Cadence Crypto
contract on-chain
#6571
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6571 +/- ##
==========================================
+ Coverage 41.12% 41.14% +0.01%
==========================================
Files 2031 2031
Lines 179589 179571 -18
==========================================
+ Hits 73862 73878 +16
+ Misses 99521 99483 -38
- Partials 6206 6210 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…entifier location
…dence-crypto-contract-onchain
Looks like this also needs an Emulator PR |
Crypto
contract on-chainCrypto
contract on-chain
Crypto
contract on-chainCrypto
contract on-chain
No idea why the integrations test fail, with odd errors like
@onflow/flow-access @onflow/flow-core-protocol could you PTAL? |
CI failures are probably due to the SDK update, which includes a few PRs which might cause this, e.g. onflow/flow-go-sdk#778. @illia-malachyn could you PTAL? |
sure. i'm looking into this |
Hi @turbolent, I've updated the SDK to align with the new protobuf message format, which now expects additional fields in the block header message. However, it seems these new fields are not being sent. I suspect that the code responsible for constructing block headers and sending them to peers hasn’t been updated to include the new fields. I initially assumed that if the protobuf message was updated, the code responsible for sending the messages would also be updated accordingly. The new fields that might be causing the issue are:
Update 1: Update 2: |
@illia-malachyn Thank you for looking into this and fixing it, much appreciated! Unfortunately, I don't know anything about it. @onflow/flow-core-protocol @onflow/flow-collection-and-consensus can someone familiar with timeout certificates please review onflow/flow-go-sdk#790? |
Work towards onflow/cadence#3135
Crypto
system contract, and e.g. deploy it to the system account during bootstrappingimport Crypto
to the chain-specific contract