Add client method for getting latest protocol state snapshot #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to version adding method for retrieving protocol state snapshot
jordanschalm
requested review from
janezpodhostnik and
turbolent
as code owners
| @@ -544,3 +544,15 @@ func getEventsResult(res *access.EventsResponse) ([]BlockEvents, error) { | |||
|
|
|||
| return results, nil | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
have the access node implementations already been done for this changes?
There was a problem hiding this comment.
It's in review onflow/flow-go#377
vishalchangrani
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward: https://github.com/dapperlabs/flow-go/issues/4899
Description
Adds a method to
sdk.Clientfor retrieving the latest protocol state snapshot (corresponding to the API added on the Access node in onflow/flow-go#377). This will be used by Flow nodes joining the network at an epoch boundary (as opposed to during a spork) to bootstrap a space-efficient local protocol state from an arbitrary state snapshot (see onflow/flow-go#209).For contributor use:
masterbranchFiles changedin the Github PR explorer