Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence v0.18 #197

Merged
merged 9 commits into from
Jul 19, 2021
Merged

Update to Cadence v0.18 #197

merged 9 commits into from
Jul 19, 2021

Conversation

turbolent
Copy link
Member

Description

Fixes

# github.com/onflow/cadence/runtime/interpreter
../../../go/pkg/mod/github.com/onflow/cadence@v0.16.1/runtime/interpreter/decode.go:43:18: undefined: cbor.StreamDecoder
../../../go/pkg/mod/github.com/onflow/cadence@v0.16.1/runtime/interpreter/decode.go:99:26: decMode.NewStreamDecoder undefined (type cbor.DecMode has no field or method NewStreamDecoder)
../../../go/pkg/mod/github.com/onflow/cadence@v0.16.1/runtime/interpreter/decode.go:117:26: decMode.NewByteStreamDecoder undefined (type cbor.DecMode has no field or method NewByteStreamDecoder)
../../../go/pkg/mod/github.com/onflow/cadence@v0.16.1/runtime/interpreter/decode.go:157:7: undefined: cbor.BoolType
../../../go/pkg/mod/github.com/onflow/cadence@v0.16.1/runtime/interpreter/decode.go:164:7: undefined: cbor.TextStringType
../../../go/pkg/mod/github.com/onflow/cadence@v0.16.1/runtime/interpreter/decode.go:171:7: undefined: cbor.NilType
../../../go/pkg/mod/github.com/onflow/cadence@v0.16.1/runtime/interpreter/decode.go:178:7: undefined: cbor.ArrayType
../../../go/pkg/mod/github.com/onflow/cadence@v0.16.1/runtime/interpreter/decode.go:181:7: undefined: cbor.TagType
../../../go/pkg/mod/github.com/onflow/cadence@v0.16.1/runtime/interpreter/decode.go:348:21: undefined: cbor.WrongTypeError
../../../go/pkg/mod/github.com/onflow/cadence@v0.16.1/runtime/interpreter/encode.go:199:19: undefined: cbor.StreamEncoder
../../../go/pkg/mod/github.com/onflow/cadence@v0.16.1/runtime/interpreter/decode.go:348:21: too many errors

See report from https://forum.onflow.org/t/unable-to-go-get-flow-go-sdk/1931


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent changed the title update to Cadence v0.16.1 Update to Cadence v0.16.1 Jun 1, 2021
@turbolent turbolent changed the title Update to Cadence v0.16.1 Update to Cadence v0.17.0 Jun 10, 2021
@turbolent turbolent changed the title Update to Cadence v0.17.0 Update to Cadence v0.18.0-patch.3 Jun 23, 2021
@turbolent
Copy link
Member Author

I've updated this further to Cadence 0.18, in particular the latest internal patch, which changed cadence.NewString.

We need to hold off merging this PR until we published the internal patches

@turbolent turbolent changed the title Update to Cadence v0.18.0-patch.3 Update to Cadence v0.18 Jul 19, 2021
@turbolent turbolent merged commit f0e283c into master Jul 19, 2021
@turbolent turbolent deleted the bastian/cadence-v0.16.1 branch July 19, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants