Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the account address generation #36

Merged
merged 13 commits into from
May 26, 2020
Merged

Update the account address generation #36

merged 13 commits into from
May 26, 2020

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented May 26, 2020

Description

This PR integrates the new account addressing mechanism.

  • integrate three addressing mechanisms (mainnet, testnet and emulator).
  • rename Root account to Service account.
  • new values for ZeroAddress and ServiceAddress.
  • provide an off-chain method to check addresses validity.

@psiemens psiemens marked this pull request as ready for review May 26, 2020 08:09
@psiemens psiemens self-requested a review as a code owner May 26, 2020 08:09
psiemens
psiemens approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@psiemens psiemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@psiemens psiemens force-pushed the tarak/1034-update-account-addresses branch from 713a92b to 7230fc2 Compare May 26, 2020 08:47
@psiemens psiemens merged commit 3bdeddc into master May 26, 2020
@psiemens psiemens deleted the tarak/1034-update-account-addresses branch May 26, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psiemens psiemens psiemens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarakby @psiemens