Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align BlockSeal type with protobuf schema #780

Conversation

illia-malachyn
Copy link
Contributor

Closes: #766

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 86.07595% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.65%. Comparing base (f5edcfd) to head (3ae9ebc).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/convert/convert.go 83.33% 6 Missing and 3 partials ⚠️
test/entities.go 92.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
- Coverage   56.67%   56.65%   -0.03%     
==========================================
  Files          35       35              
  Lines        6050     7269    +1219     
==========================================
+ Hits         3429     4118     +689     
- Misses       2127     2657     +530     
  Partials      494      494              
Flag Coverage Δ
unittests 56.65% <86.07%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/entities.go Outdated Show resolved Hide resolved
test/entities.go Outdated Show resolved Hide resolved
test/entities.go Outdated Show resolved Hide resolved
@franklywatson franklywatson merged commit fb225b9 into onflow:master Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockSeal type differs from protobuf schema
5 participants