re-enable the get block fix

onflow · May 10, 2024 · 9941b3e · 9941b3e
1 parent 0626ba1
commit 9941b3e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/fvm/environment/block_info.go b/fvm/environment/block_info.go
@@ -145,9 +145,7 @@ func (info *blockInfo) GetBlockAtHeight(
 	// Check if the requested block height is within the range of the current
 	// block height and the extra blocks in the root sealing segment.
 	if height+uint64(flow.ExtraBlocksInRootSealingSegment) < info.blockHeader.Height {
-		// TODO replace with:
-		// return runtime.Block{}, false, nil
-		return runtime.Block{}, false, errors.NewBlockHeightOutOfRangeError(height)
+		return runtime.Block{}, false, nil
 	}
 
 	header, err := info.blocks.ByHeightFrom(height, info.blockHeader)

diff --git a/fvm/environment/block_info_test.go b/fvm/environment/block_info_test.go
@@ -47,10 +47,9 @@ func TestBlockInfo(t *testing.T) {
 	require.Equal(t, lowestHeader.Height, b.Height)
 
 	// verify that the block at the height before the lowest accepted height does not exist
-	// TODO: enable the test case
-	// _, exists, err = bi.GetBlockAtHeight(lowestAcceptedHeight - 1)
-	// require.NoError(t, err)
-	// require.False(t, exists)
+	_, exists, err = bi.GetBlockAtHeight(lowestAcceptedHeight - 1)
+	require.NoError(t, err)
+	require.False(t, exists)
 }
 
 type mockBlocks struct {