Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution Node] Log the version of Go at startup #2178

Closed
fxamacker opened this issue Mar 22, 2022 · 0 comments · Fixed by #2187
Closed

[Execution Node] Log the version of Go at startup #2178

fxamacker opened this issue Mar 22, 2022 · 0 comments · Fixed by #2187
Assignees
Labels
Execution Cadence Execution Team Improvement

Comments

@fxamacker
Copy link
Member

Problem

We should log the version of Go for comparisons (using logs) to be meaningful.

Go 1.16 and Go 1.17 have different performance such as ns/op and allocs/op for the same code. For example, Go 1.17 can reportedly be 10% faster for some code. However, Go 1.17 can use more allocs/op in some other code.

The Proposed Solution

Log the version of Go using runtime.Version().

Optionally, rename :

  • "hardware specs" to "platform specs"
  • "hardware" to "platform"

In cmd/execution/main.go:

		Module("hardware specs", func(node *cmd.NodeConfig) error {
			hwLogger := node.Logger.With().Str("system", "hardware").Logger()
			err = logHardware(hwLogger)
			if err != nil {
				hwLogger.Error().Err(err)
			}
			return nil
		}).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team Improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant