Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs with more system specs #2187

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Conversation

fxamacker
Copy link
Member

Mitigations for SPECTRE-V2, SPECTRE-BHB, etc. can affect performance, so log microcode revision, kernel version, etc. at startup.

Also log Go version because performance can differ between Go 1.16 and 1.17.

Changes include:

  • Add CPU microcode revision
  • Add OS, Platform, PlatformVersion, KernelVersion, Uptime
  • Add Go version, GOMAXPROCS, NumCPU
  • rename logHardware() to logSysInfo()
  • rename "hardare specs" (logging) module to "system specs"

Closes #2178 #2183

Add CPU microcode revision
Add OS, Platform, PlatformVersion, KernelVersion, Uptime
Add Go version, GOMAXPROCS, NumCPU
@fxamacker fxamacker requested a review from m4ksio as a code owner March 23, 2022 19:57
@fxamacker fxamacker self-assigned this Mar 23, 2022
@fxamacker fxamacker requested a review from ramtinms as a code owner March 23, 2022 19:57
@fxamacker fxamacker requested a review from zhangchiqing March 23, 2022 19:57
@codecov-commenter
Copy link

Codecov Report

Merging #2187 (fb68a6a) into master (5af3bb2) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2187      +/-   ##
==========================================
- Coverage   57.54%   57.54%   -0.01%     
==========================================
  Files         642      642              
  Lines       38117    38117              
==========================================
- Hits        21935    21933       -2     
- Misses      13392    13394       +2     
  Partials     2790     2790              
Flag Coverage Δ
unittests 57.54% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/hotstuff/eventloop/event_loop.go 68.29% <0.00%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af3bb2...fb68a6a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Execution Node] Log the version of Go at startup
4 participants