Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution Node] Log more system specs at startup #2183

Closed
fxamacker opened this issue Mar 23, 2022 · 1 comment
Closed

[Execution Node] Log more system specs at startup #2183

fxamacker opened this issue Mar 23, 2022 · 1 comment
Assignees
Labels
Execution Cadence Execution Team Improvement

Comments

@fxamacker
Copy link
Member

fxamacker commented Mar 23, 2022

Problem

Changes to system specs can impact performance, so log more info (kernel version, microcode version, etc.) at startup.

E.g. for Intel CPUs, SPECTRE-BHB affects Haswell (2013) to Alder Lake (2021) and mitigations can reportedly impact performance by double-digit percents.

The Proposed Solution

Log the microcode revision, kernel version, etc. by updating logHardware() called in cmd/execution/main.go:

		Module("hardware specs", func(node *cmd.NodeConfig) error {
			hwLogger := node.Logger.With().Str("system", "hardware").Logger()
			err = logHardware(hwLogger)
			if err != nil {
				hwLogger.Error().Err(err)
			}
			return nil
		}).
@fxamacker fxamacker self-assigned this Mar 23, 2022
@fxamacker fxamacker changed the title [Execution Node] Log the CPU microcode revision [Execution Node] Log more system specs at startup Mar 23, 2022
@fxamacker
Copy link
Member Author

Closed by #2187

@fxamacker fxamacker added Improvement Execution Cadence Execution Team labels Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team Improvement
Projects
None yet
Development

No branches or pull requests

1 participant