Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Execution State] Evaluate reducing number of memory allocs by changing Payload.Key data structure #2248

Closed
fxamacker opened this issue Apr 4, 2022 · 1 comment · Fixed by #2930
Closed

[Execution State] Evaluate reducing number of memory allocs by changing Payload.Key data structure #2248

fxamacker opened this issue Apr 4, 2022 · 1 comment · Fixed by #2930
Assignees
@fxamacker
Labels
Execution Cadence Execution Team Performance

Comments

@fxamacker
Copy link
Member

fxamacker commented Apr 4, 2022 •
edited
Loading

Problem

High number of allocations involving Payload.Key was observed.

Payload.Key is a slice of KeyPart. KeyPart consists of uint16 and []byte.

Updates epic #1744

The Proposed Solution

Determine if it's feasible to modify Payload.Key to reduce number of allocations.
@fxamacker fxamacker self-assigned this Jun 3, 2022
@fxamacker fxamacker added the Execution Cadence Execution Team label Jun 16, 2022
@fxamacker
Copy link
Member Author

I'm closing this because it is addressed by PR #2930 and PR #2560.

This was referenced Sep 6, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxamacker fxamacker

Labels
Execution Cadence Execution Team Performance
Projects
None yet
Milestone
No milestone
2 participants
@fxamacker and others