(WIP) [EN Performance] Reduce memory use and speedup reading single register #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledger.Key requires 4 allocs which can be avoided when reading registers and generating proofs because we only need register path and key is an intermediate object created to compute path. To optimize reading single register, make the execution state: - use a new type ledger.KeyID to compute ledger.Path. - use KeyID which is a simplified ledger.Key with less allocs. - create ledger.TrieRead and ledger.TrieUpdate without intermidate objects such as ledger.Query and ledger.Update. With these changes, ledger.Key is only created when updating trie with new payloads. name old time/op new time/op delta ExecutionStateRead1-4 7.16µs ± 1% 6.66µs ± 1% -6.96% (p=0.000 n=9+10) name old alloc/op new alloc/op delta ExecutionStateRead1-4 1.36kB ± 0% 1.16kB ± 0% -14.98% (p=0.000 n=10+8) name old allocs/op new allocs/op delta ExecutionStateRead1-4 15.0 ± 0% 11.0 ± 0% -26.67% (p=0.000 n=10+10)
fxamacker
requested review from
ramtinms,
m4ksio and
AlexHentschel
as code owners
fxamacker
changed the title
fxamacker
changed the title
|
@fxamacker is this blocked by anything? |
fxamacker
deleted the
fxamacker/avoid-ledger-key-allocs-in-ledger-query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To reduce memory used when reading single register, make the execution state:
ledger.KeyIDto computeledger.Path.KeyIDwhich is a simplifiedledger.Keywith fewer allocs.ledger.TrieReadandledger.TrieUpdatewithout intermediate objects such asledger.Queryandledger.Update.With these changes,
ledger.Keyis only created when updating trie with new payloads.Updates #1744
Updates #2248
Closes #2559
Benchmark Comparisons